Achievo/ATK - Bugzilla – Bug 99
No validation of week numbers in hour locking feature
Last modified: 2004-01-13 08:37:18
You need to log in before you can comment on or make changes to this bug.
Reported by Thomas Eskenazi: "There is no week format control. If you choose a user and enter any ascii string in the week field, it will be accepted by Achievo."
Format checking would be good to prevent mistakes. In my oppinion it should be configurable via a config parameter, if you lock on weeks or months. An alternative implementation for function weekstamp($timestamp) to lock months would be: return strftime("%Y",$timestamp).strftime("%m",$timestamp); together with having changed some text in language file from "week" to "timespan" and not using the add lock function from time registration page, this works well.
I'll fix the validation problem for 1.0
Fixed, only valid week numbers are allowed now. Joachim: if you upgrade to 1.0 when it is released, and you still want to use the month lock instead of weeklock, you can disable the check in the week_validate method in modules/timereg/class.hours_lock.inc
Version cleanup.