Bug 99 - No validation of week numbers in hour locking feature
: No validation of week numbers in hour locking feature
Status: RESOLVED FIXED
: Achievo
Time Registration
: 0.8.*
: All All
: P3 minor
: 1.0.0
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2002-12-19 13:14 by
Modified: 2004-01-13 08:37 (History)


Attachments


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2002-12-19 13:14:52
Reported by Thomas Eskenazi:

"There is no week format control. If you choose a user and enter any ascii
string in the week field, it will be accepted by Achievo."
------- Comment #1 From 2002-12-20 11:26:41 -------
Format checking would be good to prevent mistakes. In my oppinion it should be 
configurable via a config parameter, if you lock on weeks or months. 

An alternative implementation for function weekstamp($timestamp) to lock months 
would be: 

  return strftime("%Y",$timestamp).strftime("%m",$timestamp);

together with having changed some text in language file from "week" 
to "timespan" and not using the add lock function from time registration page, 
this works well. 

------- Comment #2 From 2003-11-10 20:31:35 -------
I'll fix the validation problem for 1.0
------- Comment #3 From 2003-11-10 20:44:07 -------
Fixed, only valid week numbers are allowed now. Joachim: if you upgrade to 1.0
when it is released, and you still want to use the month lock instead of
weeklock, you can disable the check in the week_validate method in
modules/timereg/class.hours_lock.inc
------- Comment #4 From 2004-01-13 08:37:18 -------
Version cleanup.